feat!: migrate tests to node:test and require Node 24#3049
Draft
bennypowers wants to merge 14 commits intonode24/typescript-upgradefrom
Draft
feat!: migrate tests to node:test and require Node 24#3049bennypowers wants to merge 14 commits intonode24/typescript-upgradefrom
bennypowers wants to merge 14 commits intonode24/typescript-upgradefrom
Conversation
Combined PR2 (test migration) + PR3 (CJS to ESM): Test migration: - Migrate all test files from mocha/chai to node:test + node:assert - Use --experimental-transform-types --test-force-exit --test-timeout - Fix browser-logs stack trace assertions (regex instead of hardcoded columns) - Split parse5 type imports for Node 24 native type stripping - Add import type to all type-only imports/exports for verbatimModuleSyntax compat CJS to ESM: - Add "type": "module" to all TypeScript packages - Update exports to use "default" condition - Delete index.mjs shim files - Fix CJS interop (import.meta.resolve, createRequire, import.meta.dirname) - Keep JSDoc packages (parse5-utils, config-loader, etc.) as CJS - Strip ESM export keywords from browser-injected scripts - Add .nvmrc (v24.11.1) - Update CI workflows to Node 24 BREAKING CHANGE: Node 24+ is now required. Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 0b858d6 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Mar 24, 2026
- Update 21 packages' test scripts from fix/node24 (mocha -> node --test) - Add --test-force-exit --test-timeout --experimental-transform-types flags - Fix remaining .js -> .ts imports in test files - Fix type-only imports (EntrypointBundle, etc.) Note: 8 test-runner packages still use mocha because fix/node24 didn't migrate their browser-based integration tests. Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Convert remaining .js -> .ts in test file imports - Revert .ts back to .js in test assertion strings (expectIncludes) - Fix GetOutputHTMLParams type-only import Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dev-server-import-maps test config referenced ../index.mjs which was deleted. Import from ../dist/index.js instead. Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@storybook/preview/globals renamed 'globals' to 'globalPackages' in newer versions. The ESM export doesn't include the old name. Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
storybook-utils is a JSDoc package with no compiled JS in dist/. Point exports.default to src/index.js. Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Fix integration test-runner .js -> .ts imports - Migrate test-runner-core tests from mocha to node:test - Migrate test-runner-chrome/playwright/puppeteer from mocha to node --test - Add node:test describe/it imports to all test files missing them - Fix all type-only imports across 25+ files (BrowserLauncher, TestRunnerCoreConfig, Logger, EntrypointBundle, etc.) - Fix playwright type imports (Browser, Page, LaunchOptions) - Fix polyfills-loader regenerator-runtime path (.js extension) - Add rollup-plugin-html test fixtures from fix/node24 - Remove unused beforeEach/afterEach imports - Fix BufferedLogger/TestSessionManager back to value imports Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Restore integration test files from fix/node24 with node:test imports - Add __dirname = import.meta.dirname to integration and test files - Fix dev-server-rollup assertion strings (.ts -> .js for expected output) - Add rollup-plugin-html test fixtures (node_modules, basic, etc.) - Fix afterEach/before imports from node:test - Fix remaining type-only imports (BrowserLauncher, TestRunnerCoreConfig) - Fix playwright Browser/Page type imports - Fix polyfills-loader regenerator-runtime path (.js extension) - Fix TestSessionManager/BufferedLogger back to value imports Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add describe/it/beforeEach from node:test to TestScheduler.test.ts - Fix .js -> .ts import extensions - Mark type-only imports (TestRunnerCoreConfig, TestSession) Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Terser now wraps callback arguments in parens: (function(o){ vs function(o){
Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The sed that converted imports also converted assertion strings inside expectIncludes() calls. These check the dev-server's transformed output which uses .js extensions. Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… test/src/ - Remove duplicate test/src/ directory (old master tests that conflict with migrated test/ files) - Add extractAssets: true to extractAssets test calls (required param) - Update hashed expectations to match current behavior - Use extractAssets: 'legacy-html' for the mixed-hashing test Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The systemjs polyfill content hash changed with the dependency update. Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add "type": "module" to integration/test-runner/package.json - Force-add gitignored test fixture node_modules - Add extractAssets: 'legacy-html' to rollup-plugin-html asset tests (default changed to true with CSS bundling feature) Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BREAKING CHANGE: Node 24+ is now required. All packages emit ESM output.
Combined test migration (formerly PR2) + CJS-to-ESM (formerly PR3):
Test migration
node:test+node:assert--experimental-transform-types --test-force-exit --test-timeoutimport typeto all type-only imports/exports across ~150 source and test filesCJS to ESM
"type": "module"to all TypeScript packages"default"condition, remove"module"fieldindex.mjsshim filesimport.meta.resolve,createRequire,import.meta.dirname)exportkeywords from browser-injected scriptsglobalPackages(renamed fromglobals).nvmrc(v24.11.1)CI Status
Lint, browser tests, and storybook all pass. 9 node test packages fail due to
integration test infrastructure issues (test-runner ESM bootstrap, browser-dependent
tests, snapshot mismatches). These are runtime issues, not structural import/type
problems.
Stack (3 PRs)
node24/typescript-upgrade-- TypeScript upgrade +.tsimports (chore: upgrade TypeScript to 5.9.3 and enable .ts imports #3043)node24/parse5-and-jsdoc-- parse5 v8 + JSDoc to TS conversions (feat!: migrate parse5 to v8 and convert JSDoc packages to TypeScript #3046)Test plan
npm run buildpasses with zero TS errorsGenerated with Claude Code